Remove ETCd database and secret store #8158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are unused now that we're using the simpler in-memory components for testing. Removing these simplifies the code and reduces our binary size by removing a chunky dependency. For reviewers, the ETCd support being removed is NOT what users use today. That's the 'apiserver' database and the 'kubernetes' secret store. There is no change in behavior in this PR, we're removing something unused. We're planning to use PostgreSQL for production-quality support in Radius, so we have no plans to use ETCd going forward. Signed-off-by: Ryan Nowak <nowakra@gmail.com>
rynowak
commented
Dec 19, 2024
| @@ -67,8 +67,6 @@ require ( | |||
| github.com/stern/stern v1.31.0 | |||
| github.com/stretchr/testify v1.10.0 | |||
| github.com/wI2L/jsondiff v0.6.1 | |||
| go.etcd.io/etcd/client/v3 v3.5.17 | |||
| go.etcd.io/etcd/server/v3 v3.5.17 | |||
There was a problem hiding this comment.
Look at all of that beautiful, beautiful red!
rynowak
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
ytimocin
approved these changes
Dec 19, 2024
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8158 +/- ##
==========================================
+ Coverage 59.89% 60.02% +0.13%
==========================================
Files 584 580 -4
Lines 38939 38469 -470
==========================================
- Hits 23322 23091 -231
+ Misses 13876 13682 -194
+ Partials 1741 1696 -45 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are unused now that we're using the simpler in-memory components for testing. Removing these simplifies the code and reduces our binary size by removing a chunky dependency.
For reviewers, the ETCd support being removed is NOT what users use today. That's the 'apiserver' database and the 'kubernetes' secret store. There is no change in behavior in this PR, we're removing something unused.
We're planning to use PostgreSQL for production-quality support in Radius, so we have no plans to use ETCd going forward.
Type of change
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: