Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upmerge samples to edge workflow #1632

Closed
sk593 opened this issue Jul 25, 2024 · 4 comments · Fixed by #1649
Closed

Fix upmerge samples to edge workflow #1632

sk593 opened this issue Jul 25, 2024 · 4 comments · Fixed by #1649
Labels
bug Something is broken or not working as expected triaged This item has been triaged by project maintainers and is in the backlog

Comments

@sk593
Copy link
Contributor

sk593 commented Jul 25, 2024

Bug information

Steps to reproduce (required)

The upmerge samples to edge workflow fails when there's nothing to commit. This is okay since there were technically no changes but the workflow should still pass in this case

https://github.com/radius-project/samples/actions/workflows/upmerge.yaml

Observed behavior (required)

Desired behavior (required)

Workaround (optional)

System information

rad Version (required)

Operating system (required)

Additional context

AB#12892

@sk593 sk593 added the bug Something is broken or not working as expected label Jul 25, 2024
Copy link

azure-boards bot commented Jul 25, 2024

✅ Successfully linked to Azure Boards work item(s):

@sylvainsf sylvainsf added the triaged This item has been triaged by project maintainers and is in the backlog label Jul 25, 2024
@brooke-hamilton
Copy link
Contributor

/assign @brooke-hamilton

@brooke-hamilton
Copy link
Contributor

@sk593 is the desired behavior that the workflow should complete without creating a PR if there are no changes to commit?

@sk593
Copy link
Contributor Author

sk593 commented Jul 30, 2024

@sk593 is the desired behavior that the workflow should complete without creating a PR if there are no changes to commit?

yup! the upmerge workflow should keep edge up to date with the current release branch. so if there are no changes, there's no need to create a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken or not working as expected triaged This item has been triaged by project maintainers and is in the backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants