Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select primitive freezes page with preact #2557

Closed
hapaxlife opened this issue Dec 1, 2023 · 2 comments
Closed

Select primitive freezes page with preact #2557

hapaxlife opened this issue Dec 1, 2023 · 2 comments

Comments

@hapaxlife
Copy link

hapaxlife commented Dec 1, 2023

Bug report

I try to port Radix UI to preact & Fresh. All primitive work except Select

See :

Repo
Live page

Current Behavior

Every components work except Select which freezes the page (getItems has no element => error)

Expected behavior

No freeze

Reproducible example

The code with React
https://codesandbox.io/p/sandbox/select-radixui-react-klhjfn

The code with Preact : I have only change React.forwardRef to import { forwardRef } from "preact/compat";
In Fresh, I made alias/external to react
The repo to test
https://github.com/hapaxlife/select-radixui-preact

Suggested solution

@andrewiggins offers a solution to make it compatible with preact. The change will also improve performance of the primitive.

See :
preactjs/preact#4222 (comment)

@palpfiction
Copy link

Hello @hapaxlife! Is this working now?

@hapaxlife
Copy link
Author

Hi,

No it is not working. As I have no comment, I cleaned the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants