Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Cat 3 Validator Logic for SSP Active Case Data #3320

Closed
4 of 9 tasks
ADPennington opened this issue Dec 3, 2024 · 2 comments · Fixed by #3338
Closed
4 of 9 tasks

Revise Cat 3 Validator Logic for SSP Active Case Data #3320

ADPennington opened this issue Dec 3, 2024 · 2 comments · Fixed by #3338
Assignees
Labels
dev raft review This issue is ready for raft review Refined Ticket has been refined at the backlog refinement snacks

Comments

@ADPennington
Copy link
Collaborator

ADPennington commented Dec 3, 2024

Description:

Currently errors like the following are appearing in STT's SSP active error reports:
Since Item 26 (Family Affiliation) is 1, then Item 38 (Citizenship/Immigration Status) 3 must be one of (1, 2)
Since Item 60 (Family Affiliation) is 1, then Item 69 (Citizenship/Immigration Status) 3 must be one of (1, 2)

but 3 is a valid possible value for citizenship when family affiliation is 1.

Dev team: The logic here and here needs to be revised to allow 3 as a valid possible value for the Citizenship field.

UX Team: the release notes associated with this ticket should communicate the following:

Fixed:

Validation logic related SSP family affiliation and citizenship status have been fixed
TDP was incorrectly generating the following error messages for some SSP Section 1: Active Case files:

Since Item 26 (Family Affiliation) is 1, then Item 38 (Citizenship/Immigration Status) 3 must be one of (1, 2)
Since Item 60 (Family Affiliation) is 1, then Item 69 (Citizenship/Immigration Status) 3 must be one of (1, 2)

This has been resolved, and no changes to these files are needed. The TDP team will re-process the files at a later date. You may also resubmit any files impacted by this bug to obtain revised TDP-generated feedback reports, but this is not required.

Acceptance Criteria:

  • Cat 3 Validator logic for Items 26 and 38 is revised to allow 3 as an acceptable value for citizenship .
  • Error message related to Items 26 and 38 should be updated to reflect correct expected options.
  • Cat 3 Validator logic for Items 60 and 69 is revised to allow 3 as an acceptable value for citizenship .
  • Error message related to Items 60 and 69 should be updated to reflect correct expected options.
    - [ ] references to "alien" in the codebase is changed to "non-citizen" (on hold)
  • Testing Checklist has been run and all tests pass
  • README is updated, if necessary

Tasks:
Create a list of granular, specific work items that must be completed to deliver the desired outcomes of this issue

  • Update cat 3 validation logic for Items 26 and 38 here
  • Update cat 3 validation logic for Items 60 and 69 here
    - [ ] check complexity of changing references to "alien" to "non-citizen"
  • Run Testing Checklist and confirm all tests pass

Notes:

  • per @lfrohlich, we also may need to change references to "aliens" to "non-citizens" everywhere in the codebase. Change On hold pending OGC input.

Supporting Documentation:

  • per OFA TANF policy, SSP recipients can be non-qualified aliens.
    Screenshot 2024-12-03 092653
@lhuxraft lhuxraft added the snacks label Dec 3, 2024
@lhuxraft lhuxraft added the Refined Ticket has been refined at the backlog refinement label Dec 4, 2024
@ADPennington
Copy link
Collaborator Author

@victoriaatraft @reitermb -- please note that this ticket is now in qasp and has release note language referenced in the ticket. Please include this with #3316

@ADPennington
Copy link
Collaborator Author

@elipe17 i missed the child-related cat 3 error in this ticket. updated the ticket.

@elipe17 elipe17 added the raft review This issue is ready for raft review label Dec 9, 2024
@lhuxraft lhuxraft closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev raft review This issue is ready for raft review Refined Ticket has been refined at the backlog refinement snacks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants