[API] Enhance the Request class

[rsamoilov]

Description

Compared to Rails’ Request class, Rage’s Request currently has very few methods.

We'd like to update the class to include the following methods:

• host
• domain
• method
• get?/post?/patch?/put?/delete?/head?
• port
• protocol
• query_string
• remote_ip
• env

Tips

• The class is defined in lib/rage/request.rb.
• Refer to Rails Guides if you are unsure what the return value of each method should be.
• Check the overview doc that shows how Rage's core components interact with each other.
• Feel free to ask any questions or request help in the comments below!

[aaoafk]

Any reason we don't just want to compose rack behavior similar to how rails is achieving this behavior by including Rack::Request::Helpers and Rack::Request::Env?

https://api.rubyonrails.org/v8.0.1/classes/ActionDispatch/Request.html

Reviewed both those Rack modules and it looks like that's where the methods are implemented. I was able to implement host method with the following spec after including those two modules in rage/request.rb:

  fit "handles the host property of a request" do
    expect(request.host).not_to be_nil
  end

And it looks like that works

[rsamoilov]

Huh, I guess I didn't realise it existed. Let's use these modules - it makes perfect sense.

[aaoafk]

Ok. Just need to make sure that these are being used correctly / if im missing anything right now, still digesting the code from the rage, rails, and rack

[aaoafk]

Do we just want to hook into rails for some of the messages that we're missing for e.g. domain is implemented in ActionDispatch::HTTP::URL ... probably some of the other methods too that my specs are failing for... although it looks like the implementation of something like domain is straight forward...

instead of a require i think we could just extract the methods that are needed too to avoid the dependency, dunno

[rsamoilov]

We definitely don’t want to introduce the Action Dispatch dependency. And the implementation indeed seems straightforward.
https://github.com/rails/rails/blob/cf6ff17e9a3c6c1139040b519a341f55f0be16cf/actionpack/lib/action_dispatch/http/url.rb#L98