Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't convert one gp, but if i export gp as gp5 then it works #14

Open
DivannKokos opened this issue May 20, 2021 · 6 comments
Open

Can't convert one gp, but if i export gp as gp5 then it works #14

DivannKokos opened this issue May 20, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@DivannKokos
Copy link

DivannKokos commented May 20, 2021

Hi again,
Whole thing worked perfectly fine until now,
One gp file (just some tab from ultimate-guitar dot com + i change tuning to 7 string Drop-A)
Not converting
But if i export gp as gp5 file then it converts
-v:

Error: Object reference not set to an instance of an object.
   at GP6File.transferBeat(Node node, Int32 index, Voice voice)
   at GP6File.transferVoice(Node node, Int32 index, Measure bar)
   at GP6File.transferBars(Node node, GP5File song)
   at GP6File.GP6NodeToGP5File(Node node)
   at GP7File.readSong()
   at GuitarProToMidi.GpFileParser.CreateMidiFile()
   at GuitarProToMidi.Program.<>c__DisplayClass0_0.<Main>b__1()
   at Microsoft.Extensions.CommandLineUtils.CommandLineApplication.Execute(String[] args)
   at GuitarProToMidi.Program.Main(String[] args)

I also getting some other messages, but i don't think that they not connect to issue cause even if some other gp file successfully convert it still print this messages
messages like

transferNote Unrecognized node property: Midi
transferNote Unrecognized node property: TransposedPitch
transferBeat Unrecognized node property: PrimaryPickupVolume
transferBeat Unrecognized node property: PrimaryPickupTone
transferNote Unrecognized node property: ConcertPitch

but much much more, i mean huge portion of messages is same

@DivannKokos
Copy link
Author

gp file

@DivannKokos
Copy link
Author

DivannKokos commented May 20, 2021

also: i think it would be great, if there was an option, to output the -verbose log not to the console, but to a txt file or whatever file which is created in the location of the file you are converting
just to not flood console

@DivannKokos
Copy link
Author

DivannKokos commented May 20, 2021

and another also: please if possible add an option that if name of a track containing word "Bass"
it transposes all the notes on this track a one octave up
it can be done of course when you are importing midi in daw or whatever, but just small automating thing)

@rageagainsthepc
Copy link
Owner

rageagainsthepc commented May 20, 2021

Thanks for the test file, I'll have a look.

also: i think it would be great, if there was an option, to output the -verbose log not to the console, but to a txt file or whatever file which is created in the location of the file you are converting
just to not flood console

You are on Windows, right? In Powershell you could do something like this:

PS C:\Users\RandomUser> GuitarProToMidi.exe -v .\some\file.gp | Out-File -FilePath .\log.txt -Append

and another also: please if possible add an option that if name of a track containing word "Bass"
it transposes all the notes on this track a one octave up
it can be done of course when you are importing midi in daw or whatever, but just small automating thing)

I'm afraid altering the tracks is out of the scope of this project since it aims to be a simple conversion tool. Also, that's a very specific request. I don't see a general use case for it.

@rageagainsthepc rageagainsthepc added the bug Something isn't working label May 20, 2021
@DivannKokos
Copy link
Author

You are on Windows, right? In Powershell you could do something like this:

PS C:\Users\RandomUser> GuitarProToMidi.exe -v .\some\file.gp | Out-File -FilePath .\log.txt -Append

thanks, yes i am on windows, using powershell already, even don't know why, just for some reason installed a some time ago, powershell 7 preview

I'm afraid altering the tracks is out of the scope of this project since it aims to be a simple conversion tool. Also, that's a very specific request. I don't see a general use case for it.

okay, i understand

@DivannKokos
Copy link
Author

Error: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
   at System.Collections.Generic.List`1.get_Item(Int32 index)
   at GP6File.transferBars(Node node, GP5File song)
   at GP6File.GP6NodeToGP5File(Node node)
   at GP7File.readSong()
   at GuitarProToMidi.GpFileParser.CreateMidiFile()
   at GuitarProToMidi.Program.<>c__DisplayClass0_0.<Main>b__1()
   at Microsoft.Extensions.CommandLineUtils.CommandLineApplication.Execute(String[] args)
   at GuitarProToMidi.Program.Main(String[] args)

I got another error, with another file, it is again file from ultimate-guitar dot com + guitar tuned to 7string drop-a (notes as previous not changed, only internal tuning)
file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants