-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit Pull request to keras-contrib? #32
Comments
Sure. Where should the tests go? would resnet.py go into applications? |
I think tests would go in: As for model contributions I'm opening up an issue on that topic now. |
And now to come full circle, keras-team/keras-contrib#15 is the relevant github issue I created. |
The directory structure is the same as keras, so it looks like you're right about the applications folder: |
The updated implementation is now merged in keras-contrib. Could you consider adding a pointer to there in the readme of this repository? I've incorporated fairly substantial updates over there. |
Looks very good. I honestly don't have time to maintain this repo anymore. I will simply redirect users to your repo for latest changes. |
Keras has created a new official keras-contrib repository where they will accept a broader range of contributions than mainline keras, for eventual inclusion in mainline if it becomes widely used. Would you consider submitting your implementation?
https://github.com/farizrahman4u/keras-contrib
The text was updated successfully, but these errors were encountered: