Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit Pull request to keras-contrib? #32

Open
ahundt opened this issue Feb 2, 2017 · 6 comments
Open

Submit Pull request to keras-contrib? #32

ahundt opened this issue Feb 2, 2017 · 6 comments

Comments

@ahundt
Copy link

ahundt commented Feb 2, 2017

Keras has created a new official keras-contrib repository where they will accept a broader range of contributions than mainline keras, for eventual inclusion in mainline if it becomes widely used. Would you consider submitting your implementation?

https://github.com/farizrahman4u/keras-contrib

@raghakot
Copy link
Owner

raghakot commented Feb 7, 2017

Sure. Where should the tests go? would resnet.py go into applications?

@ahundt
Copy link
Author

ahundt commented Feb 7, 2017

I think tests would go in:
https://github.com/farizrahman4u/keras-contrib/tree/master/tests/keras_contrib

As for model contributions I'm opening up an issue on that topic now.

@ahundt
Copy link
Author

ahundt commented Feb 7, 2017

And now to come full circle, keras-team/keras-contrib#15 is the relevant github issue I created.

@ahundt
Copy link
Author

ahundt commented Feb 8, 2017

The directory structure is the same as keras, so it looks like you're right about the applications folder:
https://github.com/fchollet/keras/blob/master/keras/applications/resnet50.py

@ahundt
Copy link
Author

ahundt commented Oct 17, 2017

The updated implementation is now merged in keras-contrib. Could you consider adding a pointer to there in the readme of this repository? I've incorporated fairly substantial updates over there.
https://github.com/farizrahman4u/keras-contrib/blob/master/keras_contrib/applications/resnet.py

@raghakot
Copy link
Owner

Looks very good. I honestly don't have time to maintain this repo anymore. I will simply redirect users to your repo for latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants