Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail because names of pytest executable are hardcoded #25

Open
ghost opened this issue Apr 13, 2020 · 1 comment
Open

Tests fail because names of pytest executable are hardcoded #25

ghost opened this issue Apr 13, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented Apr 13, 2020

It happens because of this:

pynt/build.py

Line 18 in c0fbbc4

subprocess.call(["py.test-2.7"] + list(args))

In my system, I have both Python 2 and 3 (maybe it's worth dropping Python 2 support already?). Executables are named py.test and py.test3.

To maintain backwards compatibility, it's probably worth wrapping those subprocess calls and if they fail - try generic names.

@ghost
Copy link
Author

ghost commented Apr 13, 2020

Attempted to fix it in #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants