Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cypress (frontend UI testing) and integration image for e2e/integration testing off the dApp #1404

Closed
christianbrb opened this issue Apr 23, 2020 · 4 comments · Fixed by #1580
Closed

Use cypress (frontend UI testing) and integration image for e2e/integration testing off the dApp #1404

christianbrb opened this issue Apr 23, 2020 · 4 comments · Fixed by #1580
Assignees
@kelsos
Labels
Definition of Done ✅ Ready 🎬 Issues which are ready to be pulled into the iteration

Comments

@christianbrb
Copy link
Contributor

christianbrb commented Apr 23, 2020 •
edited
Loading

Description

Use cypress (frontend UI testing) and integration image for e2e/integration testing off the dApp.

Acceptance criteria

  • We need to check if the wizard solution (raw private key) still works (it's merged in master)

Tasks

  • [ ]
@christianbrb christianbrb added this to the Product Backlog milestone Apr 23, 2020
@christianbrb christianbrb added the Ready 🎬 Issues which are ready to be pulled into the iteration label May 11, 2020
@christianbrb
Copy link
Contributor Author

@nephix @kelsos Based on your feedback. Should we go ahead with cypress or should we implement #1511 first and check how this works?

Personally I like manual testing as it also gives useful feedback and preserves a feeling for the actual dApp.

@nephix
Copy link
Contributor

nephix commented May 14, 2020

Personally I like manual testing as it also gives useful feedback and preserves a feeling for the actual dApp

I agree

@kelsos
Copy link
Contributor

kelsos commented May 14, 2020

I agree we should fix the manual testing first. I don't see the automated tests as replacing manual testing but as complementing.

@christianbrb
Copy link
Contributor Author

@nephix @kelsos Thanks for your feedback. I have been moving this a little bit down to tackle it in the next iteration (not in this one starting today)

@kelsos kelsos self-assigned this May 26, 2020
@kelsos kelsos removed this from the Product Backlog milestone May 26, 2020
This was referenced May 26, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kelsos kelsos

Labels
Definition of Done ✅ Ready 🎬 Issues which are ready to be pulled into the iteration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Installs cypress and prepares dApp for integration image
3 participants
@kelsos @nephix @christianbrb