Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_matrix_servers has a hand rolled parser for YAML #6424

Closed
hackaugusto opened this issue Jul 27, 2020 · 0 comments · Fixed by #6442
Closed

get_matrix_servers has a hand rolled parser for YAML #6424

hackaugusto opened this issue Jul 27, 2020 · 0 comments · Fixed by #6442

Comments

@hackaugusto
Copy link
Contributor

raiden/raiden/utils/cli.py

Lines 441 to 449 in 9bd24b1

available_servers = []
for line in response.text.splitlines():
line = line.strip(string.whitespace + "-")
if line.startswith("#") or not line:
continue
if not line.startswith("http"):
line = "https://" + line # default schema
available_servers.append(line)
return available_servers

Using a hand rolled parser can be very buggy and most likely will lead to differences across clients. It seems pyyaml is not a dependency anymore, so json would be a better file format since it is used extensively on both clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant