Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl Display+Error for admin error types. #25

Closed
thedodd opened this issue Sep 22, 2019 · 0 comments · Fixed by #32
Closed

Impl Display+Error for admin error types. #25

thedodd opened this issue Sep 22, 2019 · 0 comments · Fixed by #32
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@thedodd
Copy link
Collaborator

thedodd commented Sep 22, 2019

No description provided.

@thedodd thedodd added enhancement New feature or request good first issue Good for newcomers labels Sep 22, 2019
thedodd added a commit that referenced this issue Oct 17, 2019
@thedodd
A set of changes for a 0.4.2 release.
727134a 
Fixed an issue where the value for `current_leader` was not being set
to `None` when becoming a candidate. This isn't really a *bug* per se,
as no functionality depended on this value as far as Raft is concerned,
but it is an issue that impacts the metrics system. This value is now
being updated properly.

Made the `messages::ClientPayload::new_base` constructor `pub(crate)`
instead of `pub`, which is what the intention was originally, but I
was apparently tired `:)`.

Implemented [#25](#25).
Implementing Display+Error for the admin error types.
@thedodd thedodd mentioned this issue Oct 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A set of changes for a 0.4.2 release. async-raft/async-raft
1 participant
@thedodd