Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom attributes readme issue #104

Closed
raycohen opened this issue Jul 28, 2012 · 0 comments · Fixed by #105
Closed

custom attributes readme issue #104

raycohen opened this issue Jul 28, 2012 · 0 comments · Fixed by #105

Comments

@raycohen
Copy link
Contributor

in the Custom Serializers section of the readme, as written, Person.new.attributes will error on both options and scope not being defined.

It seems like the fix might be to move both methods full_name and attribtues into an ActiveModel::Serializer class rather than an ActiveRecord::Base. However then I get wrong number of arguments on the super(options) line, and full_name needs to be changed to use object.first_name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants