-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent JSONAPI serialization when missing related serializer #1075
Comments
Check #1068 (comment) |
After giving more thoughts to this, I really think there should at least be a warning when a related serializer does not exist, because in the current situation gets very confusing when you misspel a serializer name in its definition (like |
@beauby This is still an issue, yes? |
@remear Yes, I believe so. |
This was never fixed, was it? |
Related: #1949 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Suppose we have a
Post
class withhas_many :comments
, along with aPostSerializer
. If we forget to define aCommentSerializer
, rendering aPost
with the JSONAPI adapter leads to the confusing following result (the comments are actually embedded in the relationship, which breaks JSONAPI spec):It might be helpful to either have a way to warn the user that a given model does not have a corresponding serializer defined (as suggested in #1068), or have a default behavior of serializing stuff as Resource Identifiers.
The text was updated successfully, but these errors were encountered: