Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options not passed from Json to Attributes adapters #1184

Closed
beauby opened this issue Sep 21, 2015 · 1 comment
Closed

Options not passed from Json to Attributes adapters #1184

beauby opened this issue Sep 21, 2015 · 1 comment
Labels
S: Needs Team Discussion V: 0.10.x

Comments

@beauby
Copy link
Contributor

beauby commented Sep 21, 2015

Currently, the Json adapter simply calls the Attributes adapter, and spits out the result inside a hash. However, as discussed, the former does not pass the options to the latter.
I'm not really aware of the situation of Json options, but I think this should be fixed.
@beauby beauby mentioned this issue Sep 21, 2015
Merged
@beauby
Copy link
Contributor Author

beauby commented Sep 21, 2015

Solved by #1185.

@beauby beauby closed this as completed Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S: Needs Team Discussion V: 0.10.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@beauby