We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In #1504, I figured out that in some part of the gem we do not make sure that user use the gem properly to match jsonapi specification.
The main example I ran into is when using a relationship that does not include data and do not use links and meta (Ref. #1504 (comment)):
data
links
meta
has_one :author do include_data false end # => { relationships: { author: {} } }
This results in an empty relationship and is not allowed by jsonapi specification (http://jsonapi.org/format/#document-resource-object-relationships) but the gem does not prevent the user from doing so.
Should the gem raise an error in such case or let the user figure out on its own that he's using the gem wrongly?
The text was updated successfully, but these errors were encountered:
@groyoh Was this resolved by #1516?
Sorry, something went wrong.
@remear no this was not resolved.
No branches or pull requests
In #1504, I figured out that in some part of the gem we do not make sure that user use the gem properly to match jsonapi specification.
The main example I ran into is when using a relationship that does not include
data
and do not uselinks
andmeta
(Ref. #1504 (comment)):This results in an empty relationship and is not allowed by jsonapi specification (http://jsonapi.org/format/#document-resource-object-relationships) but the gem does not prevent the user from doing so.
Should the gem raise an error in such case or let the user figure out on its own that he's using the gem wrongly?
The text was updated successfully, but these errors were encountered: