-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsonapi_parse should translate key format back again #1612
Comments
I take it this was new in RC4? My JSON API just broke all over the place with a change in key format from underscores. Not seeing a way to configure key format in the docs and these params passed back are also not deserializing. |
Key formats are new from RC4 on master. The key format defaults are desired and correctly implemented. The reverse part, the deserialization, which is in experimental stage, is not yet implemented correctly. The deserializer should know what the attributes have been transformed to since it knows where they came from. |
I'm interested to know how this would work with the given |
@pelted here's the docs on how to configure key format. I use I've closed that issue because I think its resolution will be required in order to close this issue. |
Key formats, introduced in #1248, should play into deserializing params as well.
Typically an application will store keys in underscore format. AMS should then convert them to dashed for JSON API. But, upon jsonapi_parse, they should be converted back to underscores. Currently, they are passed as dashed.
The text was updated successfully, but these errors were encountered: