Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONAPI: support RC3 features #829

Closed
3 tasks done
kurko opened this issue Mar 8, 2015 · 15 comments
Closed
3 tasks done

JSONAPI: support RC3 features #829

kurko opened this issue Mar 8, 2015 · 15 comments

Comments

@kurko
Copy link
Member

kurko commented Mar 8, 2015

  • new structure with data
    • include type in every resource
  • rename linked to included
@kurko kurko modified the milestone: 0.10 Mar 8, 2015
@joaomdmoura
Copy link
Member

👍 @kurko let me know if you need any help with this 😄

@steveklabnik
Copy link
Contributor

We just labeled an RC3, and are gonna stop changing so that you all can implement stuff ❤️

json-api/json-api#484

@zekefast
Copy link

Guys, do you need any help with that? Please, let me know! I want to faciliate development of 0.10.x and json-api standard support.

@kurko
Copy link
Member Author

kurko commented Mar 19, 2015

I won't have time to work on this until mid april. @zekefast do you have some time to craft a PR? I have time to review 😄

@zekefast
Copy link

@kurko, Yes, I do.

So, we need look into the difference of current implementation and RC3 and fill it right?
Do you have any info about currently implemented version of JSON-API standard?

@mateomurphy
Copy link
Contributor

I'm currently implementing these changes for my own use, I can also submit a PR when I'm done

@kurko
Copy link
Member Author

kurko commented Mar 19, 2015

@zekefast current master is supporting RC1. We have to move into using data as root key. @mateomurphy can you coordinate with @zekefast? :D

@kurko kurko changed the title JSONAPI: support RC2 features JSONAPI: support RC3 features Mar 19, 2015
@mateomurphy
Copy link
Contributor

@zekefast do you have anything done already, or when were you planning on working on this? I've started already as our app needs to support RC3.

@jasonkriss
Copy link
Contributor

I haven't started any work on this yet, but it's something that I'd love to land asap. I'd be happy to help. @mateomurphy is there a way we could see what you've done so far?

@mateomurphy
Copy link
Contributor

I can put together a PR tomorrow

@jasonkriss
Copy link
Contributor

That'd be great. Thanks @mateomurphy!

@zekefast
Copy link

@mateomurphy, I haven't done anything yet. I can look into your PR today and we can then coordinate work further. Please, let me know what's lack in your PR and what part of spec is missing in it.

Thanks!

@mateomurphy
Copy link
Contributor

Mostly done: #853 the main thing remaining are the URLs in links

@kurko
Copy link
Member Author

kurko commented Mar 24, 2015

yay closing

@kurko kurko closed this as completed Mar 24, 2015
@zekefast
Copy link

@mateomurphy, @kurko thank you guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants