Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing message on 'update' #228

Closed
jcoyne opened this issue Jan 5, 2024 · 2 comments · Fixed by #262
Closed

Confusing message on 'update' #228

jcoyne opened this issue Jan 5, 2024 · 2 comments · Fixed by #262

Comments

@jcoyne
Copy link

jcoyne commented Jan 5, 2024

When I run update I see a confusing message. It doesn't seem to be complete

bin/importmap update

Couldn't find any packages in [["@babel/runtime", "@lit/reactive-element", "@videojs/vhs-utils", "keycode", "lit", "lit-element", "lit-html", "m3u8-parser", "mpd-parser", "video.js"]] on

When I look for outdated packages it finds them:

bin/importmap outdated
| Package               | Current | Latest |
|-----------------------|---------|--------|
| @babel/runtime        | 7.23.5  | 7.23.7 |
| @lit/reactive-element | 1.6.3   | 2.0.2  |
| @videojs/vhs-utils    | 3.0.5   | 4.0.0  |
| keycode               | 2.2.0   | 2.2.1  |
| lit                   | 2.8.0   | 3.1.0  |
| lit-element           | 3.3.3   | 4.0.2  |
| lit-html              | 2.8.0   | 3.1.0  |
| m3u8-parser           | 6.2.0   | 7.1.0  |
| mpd-parser            | 1.2.2   | 1.3.0  |
| video.js              | 8.6.1   | 8.9.0  |
  10 outdated packages found

This is on version 2.0.1

@arni1981
Copy link
Contributor

arni1981 commented Sep 14, 2024

Can confirm this happening on Rails 7.2.1 for me.

Changing this

pin outdated_packages.map(&:name)

to be ...

pin *outdated_packages.map(&:name)

...fixed it for me locally.

@dhh
Copy link
Member

dhh commented Sep 15, 2024

Please do open a PR, @arni1981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants