Infinite redirect loop if no servers can be found

[marckohlbrugge]

Problem

When MissionControl::Jobs::Current.application.servers is empty, the application gets stuck in an infinite redirect loop. This might happen when config.active_job.queue_adapter is not set.

Why it happens

Visiting http://localhost:3000/jobs will redirect to http://localhost:3000/jobs/ which redirects to itself and so on.

This happens when there are zero MissionControl::Jobs::Current.application.servers which raises a MissionControl::Jobs::Errors::ResourceNotFound which in turn redirects to root_url which calls queues#index which starts the redirect loop again.

Proposed solution

If no servers are found, do not redirect to root_url but show an error message. Optional: If config.active_job.queue_adapter is set, suggest the user to set it as that's likely the cause for no servers being found.

[rosa]

Oops, redirecting on ResourceNotFound was a late addition and I missed this case, thanks for letting me know with this very carefully written issue 🙏 Thank you also for the proposed solution!

[rosa]

I went with something else instead: just set the async adapter like Active Job does, when there's no adapter configured, and let that bubble up as an IncompatibleAdapter error, until https://github.com/basecamp/mission_control-jobs/issues/32 is done 😅

[laran]

+1

[kidandcat]

This is happening to me with Solid Queue too
config.active_job.queue_adapter = :solid_queue

My bad, I had not enabled Solid Queue in my dev environment. Following the README steps, it works seamlessly when using Solid Queue.