Installer: don't add main in existing projects #146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses and closes #139.
Currently, the installer adds a
<main>
element around<%= yield %>
inapplication.html.erb
. This is ok for new projects, but it's annoying for projects that add this gem later on since they likely already have changed theirapplication.html.erb
and installing the gem breaks the layout.This proposed change first checks if
application.html.erb
looks standard around<%= yield %>
, and only in that case wraps it in a<main>
element.