Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant font-size class from generators #97

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Remove redundant font-size class from generators #97

merged 1 commit into from
Dec 18, 2021

Conversation

weizheheng
Copy link
Contributor

Signed-off-by: Marcus Heng marcushwz@gmail.com

There are redundant class names for font-size in some of the default generators. This is what get generated when I do:

rails g controller static_pages home

image

In this PR, I have removed the text-lg from the affected generators. The comparison of text-lg and text-4xl are as follow:

  • text-4xl

image

  • text-lg

image

Signed-off-by: Marcus Heng <marcushwz@gmail.com>
Copy link
Contributor

@dixpac dixpac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍❤️

@dhh dhh merged commit 91406c2 into rails:main Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants