Skip to content

Commit

Permalink
Remove success message on webpacker:install
Browse files Browse the repository at this point in the history
Currently, the last line of output when running `rails new` is
"Webpacker successfully installed" which is somewhat confusing if you
don't read all of the intermediate output from that command. After
proposing rails/rails#42546 to add a clear
success message to the end of `rails new`, @rafaelfranca and others
recommended removing the success message from webpacker to be more in
line the Unix philosophy of not saying anything when things go well.
  • Loading branch information
supersam654 committed Jun 26, 2021
1 parent beb645e commit c124aa7
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions lib/install/template.rb
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,7 @@
say "policy.connect_src :self, :https, \"http://localhost:3035\", \"ws://localhost:3035\" if Rails.env.development?", :yellow
end

if results.all?
say "Webpacker successfully installed 🎉 🍰", :green
else
unless results.all?
say "Webpacker installation failed 😭 See above for details.", :red
exit 1
end

0 comments on commit c124aa7

Please sign in to comment.