Skip to content

Commit c124aa7

Browse files
committed
Remove success message on webpacker:install
Currently, the last line of output when running `rails new` is "Webpacker successfully installed" which is somewhat confusing if you don't read all of the intermediate output from that command. After proposing rails/rails#42546 to add a clear success message to the end of `rails new`, @rafaelfranca and others recommended removing the success message from webpacker to be more in line the Unix philosophy of not saying anything when things go well.
1 parent beb645e commit c124aa7

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

lib/install/template.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,7 @@
6868
say "policy.connect_src :self, :https, \"http://localhost:3035\", \"ws://localhost:3035\" if Rails.env.development?", :yellow
6969
end
7070

71-
if results.all?
72-
say "Webpacker successfully installed 🎉 🍰", :green
73-
else
71+
unless results.all?
7472
say "Webpacker installation failed 😭 See above for details.", :red
7573
exit 1
7674
end

0 commit comments

Comments
 (0)