We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per my review of #2802 (review)
We need to do something about the removal of extract_css from config/webpacker.yml
extract_css
config/webpacker.yml
AFAIK, if one wants to use HMR with CSS, with the webpack-dev-server, in development mode, then we want CSS to come from the regular JS Bundle, so:
webpack-dev-server
mini-css-extract-plugin
CC: @gauravtiwari
The text was updated successfully, but these errors were encountered:
@gauravtiwari this may have changed in Webpack v5.
https://webpack.js.org/plugins/mini-css-extract-plugin/#hot-module-reloading-hmr
I'm investigating.
Did you test the React HMR with CSS changes?
Sorry, something went wrong.
@justin808 @gauravtiwari Maybe this issue can be related? --> #2832
Because css modules is probably the main way that hot loading of CSS works...
Per webpack-contrib/mini-css-extract-plugin#519 (comment), we need to use the style-loader for HMR.
See fix in #3031.
No branches or pull requests
Per my review of #2802 (review)
We need to do something about the removal of
extract_css
fromconfig/webpacker.yml
AFAIK, if one wants to use HMR with CSS, with the
webpack-dev-server
, in development mode, then we want CSS to come from the regular JS Bundle, so:mini-css-extract-plugin
CC: @gauravtiwari
The text was updated successfully, but these errors were encountered: