Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Packs are not recompiled when changed #468

Closed
richseviora opened this issue Jun 3, 2017 · 2 comments
Closed

Test Packs are not recompiled when changed #468

richseviora opened this issue Jun 3, 2017 · 2 comments
Labels
enhancement

Comments

@richseviora
Copy link

richseviora commented Jun 3, 2017 •
edited
Loading

Opening issue for visibility.

As mentioned in the discussion in PR #360, test packs are not recompiled when changed. If the packs-test directory (or your default) already exists, subsequent changes to app/javascript/pack will not cause the packs-test directory to be regenerated.

Webpacker::Manifest.lookup checks to see if the file is found (.find) but there's no freshness check.
@gauravtiwari
Copy link
Member

@richseviora Please see this comment - #360 (comment)

@justin808
Copy link
Contributor

@richseviora See #464. Also, I wrote the code for React on Rails that does this. We use the file mtimes.

@gauravtiwari gauravtiwari mentioned this issue Jun 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gauravtiwari @justin808 @richseviora