Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional config validation (using dry-validation schema) #155

Merged
merged 2 commits into from
Dec 20, 2016
Merged

Add optional config validation (using dry-validation schema) #155

merged 2 commits into from
Dec 20, 2016

Conversation

ok32
Copy link

@ok32 ok32 commented Oct 29, 2016

Tests are present, docs are not. : )

@pkuczynski
Copy link
Member

We would need some docs and fix failing build, before we can accept this PR :)

@ok32
Copy link
Author

ok32 commented Nov 1, 2016

Here come the docs.
As for the build, I'm afraid there's bad news. It won't build with rubies older than 2.1. I didn't know about this limitation until I saw the failing build. This isn't good, is it?

@pkuczynski pkuczynski changed the base branch from master to validation December 20, 2016 00:55
@pkuczynski pkuczynski merged commit 88fcd48 into rubyconfig:validation Dec 20, 2016
pkuczynski pushed a commit that referenced this pull request Dec 22, 2016
Ignore validation for Ruby older then 2.1.
7e94685 
Move tests to separate file.
Add validation to example initializer.

Fixes #155
@aspirewit aspirewit mentioned this pull request May 31, 2017
Closed
@pkuczynski pkuczynski added this to the 1.5.0 milestone Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ok32 @pkuczynski