Add count to the reserved names list #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkuczynski
requested changes
Mar 23, 2017
pkuczynski
reviewed
Mar 23, 2017
spec/fixtures/reserved_keywords.yml
Outdated
| @@ -1,2 +1,4 @@ | |||
| select: 123 | |||
| collect: 456 | |||
| section: | |||
There was a problem hiding this comment.
Why adding this keyword deeper in the tree instead of on the same level as other reserved keywords?
carbonin
force-pushed
the
add_count_to_reserved_names
branch
from
bfb60b1
to
50540e3
Compare
|
Sorry about that. Just fixed it up. |
|
No worries. Looks good. Thanks! :) |
pkuczynski
approved these changes
Mar 23, 2017
carbonin
added a commit
to carbonin/manageiq
that referenced
this pull request
Jan 8, 2018
This pulls in rubyconfig/config#167 which allows us to reference keys called "count" properly
carbonin
added a commit
to carbonin/manageiq
that referenced
this pull request
Jan 8, 2018
This pulls in rubyconfig/config#167 which allows us to reference keys called "count" properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into this issue by using
:countas a key in our settings here/cc @yrudman @Fryguy