-
Notifications
You must be signed in to change notification settings - Fork 620
Set up Docker #15
Comments
|
@jonadev95, that's the plan. |
A little addition to the second point, so they should work inside the container? |
I don't have enough knowledge to answer that, but the goal is to make the development easy. I guess it would be harder to work inside the container, right? Please collaborate with @kblanks, he's also working on that. |
@jonadev95 I'm cool if you want to do this yourself, I'll find another issue to work on 👍 |
@jonadev95 - Once we have an approved container, I will add the docker build / publish to Travis ( See #63 ) |
@joshtoo great! |
@joshtoo, as I know Travis already run builds in dockers. Or you just want to create docker image using Travis? |
@G07cha If I understand it the right way, he means that he will add a job to build the dockerfiles and push them automatically to the docker hub repo. |
Okay, I get it, but first of all we need to make black-screen stable build for Linux becouse all docker images are linux-based. |
@G07cha I've tried it on my linux pc (Because I didn't see note that it's only for OS X ), and with gulp it works very well. But if you think it's better to wait until it's stable I will write it based on the current state, but will wait for the stable release before opening a pull request. |
This looks awesome. I've been playing with this project on Ubuntu, and aside from some "JavaScript error occurred in the main process" error popups, this looks promising. Have you thought of running the GUI interface within the container, using the host's Xserver with Unix sockets? |
@ruffsl Do you mean the container which should run the tests? Or the one which isn't build yet to be like an sdk? |
@ruffsl Yes if thought about it (And I've already used this workaround for myself), but IMO we should make shure that we don't affect the host in any way, But of course that's just my opinion, we should discuss it! 👍 |
I'm new to this project, so I'm not sure of your question. I was thinking that if someone wanted to get started with a working dev environment, an also interactively run the app from the same container, this could be done. An example wiki I started in using GUI apps with docker: There are ways doing this without elevating the container to privileged status though. This was the first project I found way back when that first did this: |
@ruffsl youre completely right, that's exactly what should be done. Okay I didn't know that you mean all possible ways to get 'graphics from docker', but as said I think to keep everything safe and seperated we should go with SSH. Yes you're right, didn't know that, sorry. Maybe some others should bring in their opinions. |
npm test
(seepackage.json
for other scripts) to run those specs.The text was updated successfully, but these errors were encountered: