Skip to content
This repository has been archived by the owner on May 21, 2019. It is now read-only.

Automate build? #28

Closed
jcgertig opened this issue Sep 6, 2015 · 10 comments
Closed

Automate build? #28

jcgertig opened this issue Sep 6, 2015 · 10 comments
Labels

Comments

@jcgertig
Copy link

jcgertig commented Sep 6, 2015

Maybe look into https://github.com/mainyaa/gulp-electron and https://codeship.com so that you can build a executable for all platforms automatically on a successful deploy.

@vlad-shatskyi
Copy link
Contributor

That is a great idea. I'll try to do it, but if you're interested in contributing and want to make it happen sooner, you're welcome to go ahead. If you need access to the repository, please let me know and I'll add you.

@jcgertig
Copy link
Author

jcgertig commented Sep 6, 2015

Sure I can start

@jcgertig
Copy link
Author

jcgertig commented Sep 8, 2015

you can see what Im working on here https://github.com/jcgertig/black-screen/tree/add-auto-build

@vlad-shatskyi
Copy link
Contributor

@jcgertig, please open a pull request. I will automatically update with your latest changes in the branch. Make sure to make it as work in progress.

@joshwiens
Copy link

@ShockOne - I don't think he was quite done. We are splitting tasks as we get to them from #63 some of which are dependent on each others work. His PR will be opened to https://github.com/black-screen/black-screen/tree/63_travis-ci as will all the others from #63

@vlad-shatskyi
Copy link
Contributor

@jcgertig are you still working on this?

@jcgertig
Copy link
Author

Sorry ive been sick. Yeah all I need to add is a tagging and push back to github

@vlad-shatskyi
Copy link
Contributor

@jcgertig you have nothing to be sorry about. Hope you feel better now.

@jcgertig
Copy link
Author

have you been able to fix the

Uncaught Error: Invariant Violation: addComponentAsRefTo(...): Only a ReactOwner can have refs. This usually means that you're trying to add a ref to a component that doesn't have an owner (that is, was not created inside of another component's `render` method). Try rendering this component inside of a new top-level component which will hold the ref.

that you get when you package?

it happens for prompt.js

@dantman
Copy link

dantman commented Oct 13, 2015

I've found that addComponentAsRefTo often happens in React based code when you have 2 copies of React.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants