Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin doesn't work with php 7.4 please update #92

Closed
summercms opened this issue Nov 30, 2019 · 2 comments
Closed

Plugin doesn't work with php 7.4 please update #92

summercms opened this issue Nov 30, 2019 · 2 comments

Comments

@summercms
Copy link

I'm seeing this message:

Deprecated: implode(): Passing glue string after array is deprecated

In the dashboard widgets, see below for example:

image

The problem that the previous versions of implode allowed the array and glue string parameters in either order. 7.4 is more precise on the order of parameters. The old way that could work before was:

<?php
$data = [
'Apple',
'Orange',
'Pear,
];
implode($data, ',');

To fix it, simply swap the variables for future versions of php.

<?php
$data = [
'Apple',
'Orange',
'Pear
];
implode(',' , $data);
@LukeTowers
Copy link
Contributor

@ayumi-cloud submit a PR and I'll review it.

@summercms
Copy link
Author

  • I think this error is coming from October CMS side and not this plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants