Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommendation: put nerd-icons-dired and nerd-icons-completion in this repo #8

Open
milanglacier opened this issue Apr 21, 2023 · 6 comments

Comments

@milanglacier
Copy link

minibuffer completion and dired are emacs builtin features. I see no reasons why we don't want to put those two extensions into this repo. They can be separated files, but including them in this repo makes totally sense.

It's like consult has included many extensions like consult-buffer, consult-ripgrep stuffs in the consult repo.

@milanglacier milanglacier changed the title recommendation: put nerd-icons-dired and nerd-icons-completion in this branch recommendation: put nerd-icons-dired and nerd-icons-completion in this repo Apr 21, 2023
@rainstormstudio
Copy link
Owner

Actually this makes sense. I'll consider this. :)

@milanglacier
Copy link
Author

milanglacier commented Apr 22, 2023

Pros for this consideration:

since this is a new project, we want this project gain popularity as quick as possible. Putting essential features into separate repos is definitely not a good decision since I can bet 99% of users want to display icons in minibuffer and dired and they need to visit multiple repos and install many packages for one thing.

@seagle0128
Copy link
Collaborator

seagle0128 commented Apr 23, 2023

Also for ibuffer? It's here currently, and already been released to melpa.

I don't think it's a big problem, whatever they are merged into one repo. Same situation for all-the-icons. It's just a core, and other packages are extensions.

@jcs090218
Copy link
Contributor

I've also created a simple plugin for buffer-menu, see jcs-elpa/nerd-icons-buffer-menu. :D

@Thaodan
Copy link
Contributor

Thaodan commented Nov 14, 2023

Also for ibuffer? It's here currently, and already been released to melpa.

I don't think it's a big problem, whatever they are merged into one repo. Same situation for all-the-icons. It's just a core, and other packages are extensions.

It seems silly to install a new package for each tiny feature where the Readme plus Cask is about the same size as the package itself.

@hab25
Copy link

hab25 commented May 17, 2024

Counter argument: this would make it harder (impossible?) to communicate API breaking changes via git tags and semantic versioning at the level of granularity of those extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants