Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate out Campaigns from .raisely.json #37

Open
danalexilewis opened this issue Jul 14, 2022 · 1 comment
Open

Seperate out Campaigns from .raisely.json #37

danalexilewis opened this issue Jul 14, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@danalexilewis
Copy link

I realised that the UUIDs of campaigns may be something I could commit in my repo. While everything else definetly shouldn't be.

The reasoning, it enables me to create multiple github repos targeting different sets of campaigns. AND makes it a lot easier to onboard different devs into differend projects/clients work.

If my repo is public than yes I am exposing the uuid to the internet, which is not ideal. But to be honest I think its ok a malicious third party would still not have the API key or the login credentials.

Alternatively It would be good to set this via a seperate .env so we can share this amongst the developers while expecting each of them to still login with their own account.

@tommaitland tommaitland added the enhancement New feature or request label Jul 15, 2022
@tommaitland
Copy link
Contributor

Thanks Dan – we don't consider campaign UUIDs private so yes, there's no real risk doing this. The .raisely.json file shouldn't be committed (and I believe we have checks to warn this if it is).

Happy to consider this with broader improvements to choosing the campaign when starting a CLI project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants