Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block>elem>tag>elem not working #20

Open
linvain opened this issue Sep 27, 2018 · 1 comment
Open

block>elem>tag>elem not working #20

linvain opened this issue Sep 27, 2018 · 1 comment

Comments

@linvain
Copy link

linvain commented Sep 27, 2018

block>elem>tag>elem not working:

<footer block="footer">
  <div elem="column">
    <a href="#">
      <img elem="img" src="img/app-store.png" alt="" />
    </a>
    <a href="#">
      <img elem="img" src="img/google-play.png" alt="" />
    </a>
  </div>
</footer>

img tag renders as <img elem="img" src="/app-store.170656b3.png" alt="">

Still block>elem>elem>elem works (adding elem attribute on img tag solves the issue)

@rarila
Copy link

rarila commented Apr 5, 2019

I can confirm this issue!
I just like to add another, more generic example:

Working example

Source:

<div block="block">
    <div elem="element-one">
        <div elem="element-two">
            <div elem="element-three">OK</div>
        </div>
    </div>
</div>

Result, as expected:

<div class="block">
    <div class="block__element-one">
        <div class="block__element-two">
            <div class="block__element-three">OK</div>
        </div>
    </div>
</div>

Buggy example

Source:

<div block="block">
    <div elem="element-one">
        <div>
            <div elem="element-two">ERROR</div>
        </div>
    </div>
</div>

Results in elem attribute not replaced with class:

<div class="block">
    <div class="block__element-one">
        <div>
            <div elem="element-two">ERROR</div>
        </div>
    </div>
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants