Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clicking empty cells causes JS error #59

Closed
justinobney opened this issue Aug 19, 2015 · 8 comments
Closed

clicking empty cells causes JS error #59

justinobney opened this issue Aug 19, 2015 · 8 comments

Comments

@justinobney
Copy link

Error image

@rajeshwarpatlolla
Copy link
Owner

I can't see any image or any error in the demo. Please use this link. http://rajeshwarpatlolla.github.io/DatePickerForIonicFramework/demo/#/tab/date-picker

@justinobney
Copy link
Author

Still getting issue: https://db.tt/uCLsmIHr

In the demo, the 31st is orphaned in a new row (only date left in month) I am simply clicking where the 3rd of the next month would be, if it were rendered. See the cursor position in the image.

@rajeshwarpatlolla
Copy link
Owner

I can see it now. Thanks for finding this issue. I am working on a new version of this component. I will try to fix this issue in that new version. May be you can expect that new new version in the next few hours.

@rajeshwarpatlolla
Copy link
Owner

This bug has been fixed. You can the new version i.e. v0.8.0.

@rajild
Copy link

rajild commented Sep 12, 2015

This issue still persist in example given at below URL:
http://rajeshwarpatlolla.github.io/DatePickerForIonicFramework/demo/#/tab/date-picker

See below image:
image

Steps:

  1. open date picker.
  2. click on empty cell at the div i shown in above image.
  3. date will set to nan and after setting this, date picker is not opening.

is there any way to solve this?

@rajeshwarpatlolla
Copy link
Owner

Yes, you are right. I can see it there. I will check the source code and will let you know, once it is fixed.

@rajild
Copy link

rajild commented Sep 12, 2015

Thanks a lot for quick reply. I think you can fix it by skipping this div for empty dates. Awaiting your reply.

Also, for pop-up mode, the date picker is quiet slow. Due to this multiple instances are opening when user clicks multiple times this also leads to application crash. I am going to try using model as suggested by you in another post.

@rajeshwarpatlolla
Copy link
Owner

Issue resolved. Code pushed to master branch. Please take a look at this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants