Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel filtering doesn't look right ... #11

Open
kisielk opened this issue Jul 20, 2014 · 1 comment
Open

Channel filtering doesn't look right ... #11

kisielk opened this issue Jul 20, 2014 · 1 comment

Comments

@kisielk
Copy link
Collaborator

kisielk commented Jul 20, 2014

I haven't tried it yet but I've just been reading the code

You define:

type Channel int

So using a filter that's Channel(1) | Channel(3) will just get me channel 3...

The C version has a macro called Pm_Channel which is 1 << channel so I think you probably want to change Channel to be a function that returns the same in order to generate a bitmask.
@rakyll
Copy link
Owner

rakyll commented Jul 21, 2014

Good catch, never tested masking. I'll fix it once I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kisielk @rakyll