Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchors on the help page don't scroll correctly on first load #1115

Closed
1 task
louise-davies opened this issue Jul 4, 2022 · 0 comments · Fixed by #1118
Closed
1 task

Anchors on the help page don't scroll correctly on first load #1115

louise-davies opened this issue Jul 4, 2022 · 0 comments · Fixed by #1118
Assignees
Labels
bug Something isn't working

Comments

@louise-davies
Copy link
Member

Description:
Anchor links within the help page work, but if we try to reload the page or click a link to a specific help heading, then the page isn't scrolled to the correct heading. I believe this is due to the headers only loading in after the browser tries to navigate to the anchor links, and so we'll need to manually scroll. A solution similar to this should work: https://ericdcobb.medium.com/scrolling-to-an-anchor-in-react-when-your-elements-are-rendered-asynchronously-8c64f77b5f34

Acceptance criteria:

  • Hashes in help page url correctly scroll to the corresponding headers on page load
@louise-davies louise-davies added the bug Something isn't working label Jul 4, 2022
@kennethnym kennethnym self-assigned this Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants