Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force refresh when site is taken out of maintenance mode #1312

Closed
2 tasks
louise-davies opened this issue Sep 29, 2023 · 0 comments · Fixed by #1315
Closed
2 tasks

Force refresh when site is taken out of maintenance mode #1312

louise-davies opened this issue Sep 29, 2023 · 0 comments · Fixed by #1315
Assignees
Labels
admin Functionality for admin users enhancement New feature or request good first issue Good for newcomers user feedback Issues that were raised by users

Comments

@louise-davies
Copy link
Member

Description:
This helps when doing a bugfix upgrade - we can ensure that no users have the old version of the code in their browser loaded after a certain period of time (i.e. how long SG checks for maintenance). For other circumstances - forcing a reload after maintenance mode is fairly non-intrusive - the only thing that is lost is any caching that the plugins may do. For this to work, we'd need to bump up the frequency of how often we check for maintenance mode changes - probably every 5 minutes is more suitable than every hour.

Acceptance criteria:

  • When SG detects it's gone from maintenence mode true to false, it forces a page refresh. Easiest place to do this is probably the middleware I think. We don't need to use react-router reload method if it's more complex, basic window.location.reload() will do.
  • Maintenance mode is checked for more frequently
@louise-davies louise-davies added good first issue Good for newcomers admin Functionality for admin users user feedback Issues that were raised by users enhancement New feature or request labels Sep 29, 2023
@kaperoo kaperoo linked a pull request Oct 9, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Functionality for admin users enhancement New feature or request good first issue Good for newcomers user feedback Issues that were raised by users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants