Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A step missing in the setup documentation #12

Closed
spetrosi opened this issue May 26, 2023 · 1 comment
Closed

A step missing in the setup documentation #12

spetrosi opened this issue May 26, 2023 · 1 comment

Comments

@spetrosi
Copy link

After creating a repo from your template repo I need to make an additional step:
Go to Settings > Actions > General > in Workflow permissions select Read and Write permissions.
This is required by https://github.com/JamesIves/github-pages-deploy-action and because you use this action it is worth mentioning.

One nitpick is to have the setup procedure in steps not in subtitles for readability.

Thank you

@ralexander-phi
Copy link
Collaborator

Thanks for raising this issue! I missed this step.

Looking into it some more, I see that I can add permissions directly to the job in the workflow (more details linked in the PR). This way the workflow won't need an extra setup step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants