Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate deserialization routines #82

Closed
ralexstokes opened this issue Jun 26, 2023 · 1 comment
Closed

consolidate deserialization routines #82

ralexstokes opened this issue Jun 26, 2023 · 1 comment
Labels
good first issue Good for newcomers
Milestone

Comments

@ralexstokes
Copy link
Owner

#81 consolidated the serialization routines, with a major benefit of letting the ser code in the proc macro call out to the one set of routines in the main library

let's do a similar refactor for deserialization

I'd say this is a "good first issue" if you just mirror the approach in #81 for serialization code

@ralexstokes ralexstokes added the good first issue Good for newcomers label Jun 26, 2023
@ralexstokes ralexstokes added this to the v1.0 milestone Jun 26, 2023
@ralexstokes
Copy link
Owner Author

after some thought, this doesn't seem to pull its weight as it would mainly just save the extra deserialization maintenance for containers -- happy to entertain a PR here if someone sees this in the future and thinks it would add value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant