Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty background image property behaving incorrectly #490

Open
RyanCoulsonCA opened this issue Oct 18, 2024 · 0 comments
Open

Empty background image property behaving incorrectly #490

RyanCoulsonCA opened this issue Oct 18, 2024 · 0 comments
Assignees
Labels
Bug Something that probably needs fixing Priority: High This task is high priority and should be tackled soon

Comments

@RyanCoulsonCA
Copy link
Member

Description

If a slide is given an empty background image property (i.e., "backgroundImage": ""), the string will be taken literally and the app will set the background image source to the empty string which results in all kinds of funkiness.

Environment

  • Browser (if applicable): Any

Screenshots

image

Expected behavior

If the property is set to an empty string, we should assume the product author does not want a background image and display the white background.

Actual behavior

The intentionally-displayed background image will appear over this slide, but there will also be no white box around the text or content.

Possible solution

This is already fixed in #488. Creating this issue for tracking purposes.

@RyanCoulsonCA RyanCoulsonCA added Bug Something that probably needs fixing Priority: High This task is high priority and should be tackled soon labels Oct 18, 2024
@RyanCoulsonCA RyanCoulsonCA self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something that probably needs fixing Priority: High This task is high priority and should be tackled soon
Projects
None yet
Development

No branches or pull requests

1 participant