Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly read from the environment variables with from_env #116

Closed
marioortizmanero opened this issue Aug 16, 2020 · 0 comments · Fixed by #129
Closed

Explicitly read from the environment variables with from_env #116

marioortizmanero opened this issue Aug 16, 2020 · 0 comments · Fixed by #129
Labels
enhancement New feature or request

Comments

@marioortizmanero
Copy link
Collaborator

marioortizmanero commented Aug 16, 2020 •
edited
Loading

Calling SpotifyClientCredentials::default() automatically tries to read the environment values for CLIENT_ID and CLIENT_SECRET. I think this shouldn't be the default behavior, meaning that the current default method should become from_env, and have a default method that simply sets the values to None.

This is also done by the tekore library, for example.

This should be done after #109 is taken care of. I have to check if any other structs apart from SpotifyClientCredentials do anything similar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiple clients via features ramsayleung/rspotify
1 participant
@marioortizmanero