Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --description-from-stdin option to snapshot creation #5881

Closed
Tracked by #5876
jandubois opened this issue Oct 31, 2023 · 2 comments · Fixed by #6120
Closed
Tracked by #5876

Add --description-from-stdin option to snapshot creation #5881

jandubois opened this issue Oct 31, 2023 · 2 comments · Fixed by #6120
Assignees
Labels
area/snapshots component/rdctl kind/story Work item that is linked from a kind/epic
Milestone

Comments

@jandubois
Copy link
Member

On Windows the commandline has a maximum length of 32KB, which limits the amount of data you can pass to the --description option (see #5843).

An easy way around this would be to add an alternative --description-from-stdin option, so the app could pipe the description to rdctl.

It is arguable that 32KB should be plenty enough for a snapshot description, but it is possible that the description may be autogenerated from manifests of all the workloads installed inside the VM, so it is better to not have an artificial limit.

@ericpromislow
Copy link
Contributor

I would add support for --description-from-file FILE because stdin on powershell isn't so simple, so some users might not be comfortable with it.

@jandubois
Copy link
Member Author

I would add support for --description-from-file FILE

I'm fine with this as long as --description-from file - works as well, to implement --description-from-stdin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/snapshots component/rdctl kind/story Work item that is linked from a kind/epic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants