Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore snapshot needs to signal when data has been reset #5882

Closed
Tracked by #5876
jandubois opened this issue Oct 31, 2023 · 0 comments · Fixed by #6030
Closed
Tracked by #5876

Restore snapshot needs to signal when data has been reset #5882

jandubois opened this issue Oct 31, 2023 · 0 comments · Fixed by #6030
Assignees
Labels
area/snapshots component/rdctl kind/story Work item that is linked from a kind/epic
Milestone

Comments

@jandubois
Copy link
Member

We need to be able to include the information about the data reset (let's stop calling it factory reset) with the error message, like e.g.

{"error": "restore failed because reasons", "dataReset": true }

That way the UI will now if the data has been reset or not, and can act differently depending on this value.

One thing that isn't clear to me right now: What does the UI do if the JSON stream includes multiple errors? Do we show all, or stop at the first one? Would we need to add dataReset to all of them?

Originally posted by @jandubois in #5844 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/snapshots component/rdctl kind/story Work item that is linked from a kind/epic
Projects
None yet
3 participants