Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Self Hosted Runner setup link is broken in docs/development/github-runner-setup.md #7754

Open
stevem995 opened this issue Nov 10, 2024 · 1 comment
Labels
kind/bug Something isn't working kind/documentation triage/needs-information Further information is requested

Comments

@stevem995
Copy link

Actual Behavior

Link to Github Runner installation is missing.

Steps to Reproduce

  1. Open the docs:
    https://github.com/rancher-sandbox/rancher-desktop/blob/main/docs/development/github-runner-setup.md
  2. Click the link on step 9 labeled instructions:
    Install GitHub Actions runner following instructions (on the page to add a runner, not the help documentation).
    This produces a 404 file not found.

Result

https://github.com/rancher-sandbox/rancher-desktop/settings/actions/runners/new?arch=x64&os=win
Produces a 404 error.

Expected Behavior

Link to instructions work.

Additional Information

Trying to add a self-hosted runner to an existing Windows 11 Rancher desktop installation.

Rancher Desktop Version

1.8.1

Rancher Desktop K8s Version

1.26.0

Which container engine are you using?

moby (docker cli)

What operating system are you using?

Windows

Operating System / Build Version

Windows 11 Home

What CPU architecture are you using?

x64

Linux only: what package format did you use to install Rancher Desktop?

N/A

Windows User Only

No

@stevem995 stevem995 added the kind/bug Something isn't working label Nov 10, 2024
@jandubois
Copy link
Member

We no longer use self-hosted GitHub runners since the runners provided by GitHub now support nested virtualization.

Trying to add a self-hosted runner to an existing Windows 11 Rancher desktop installation.

I'm not sure what this is supposed to mean. The GitHub runners are not something you "add" to a Rancher Desktop installation; it is a machine used to build Rancher Desktop as part of building/testing pull requests.

@jandubois jandubois added triage/needs-information Further information is requested kind/documentation labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/documentation triage/needs-information Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants