Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch creates unwanted overlay when CRDs have an upstream #142

Closed
joshmeranda opened this issue Jul 26, 2024 · 1 comment
Closed

Patch creates unwanted overlay when CRDs have an upstream #142

joshmeranda opened this issue Jul 26, 2024 · 1 comment

Comments

@joshmeranda
Copy link
Contributor

Introduced in #129 when running make patch on a chart with a CRD chart that pulls from an upstream source, an unexpected generated-changes/overlay/crds is created. While this does not affect make prepare because we delete the CRDs from the main chart, this does clutter the generated-changes directory with unnecessary files and requires developers manually removing the directory after each make patch to avoid this.

To Reproduce

> git switch dev-v2.9
Switched to branch 'dev-v2.9'
Your branch is up to date with 'origin/dev-v2.9'.
> USE_CACHE=1 PACKAGE=rancher-monitoring/rancher-monitoring make prepare
...
> USE_CACHE=1 PACKAGE=rancher-monitoring/rancher-monitoring make patch
...
> git status
On branch dev-v2.9
Your branch is up to date with 'origin/dev-v2.9'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        packages/rancher-monitoring/rancher-monitoring/charts-crd/
        packages/rancher-monitoring/rancher-monitoring/charts/
        packages/rancher-monitoring/rancher-monitoring/generated-changes/overlay/crds/

nothing added to commit but untracked files present (use "git add" to track)
@nicholasSUSE
Copy link
Collaborator

Resolved by this: #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants