Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with chart dependencies #68

Open
eliaskoromilas opened this issue Nov 27, 2021 · 1 comment
Open

Problem with chart dependencies #68

eliaskoromilas opened this issue Nov 27, 2021 · 1 comment
Assignees
Labels
bug Something isn't working team/mapps

Comments

@eliaskoromilas
Copy link

The following line messes with how Helm 3 handles dependencies:

https://github.com/rancher/charts-build-scripts/blob/v0.2.4/pkg/charts/dependencies.go#L257

more at rancher/partner-charts#265

@aiyengar2 aiyengar2 self-assigned this Jan 28, 2022
@aiyengar2 aiyengar2 added bug Something isn't working [zube]: To Triage labels Jan 28, 2022
@aiyengar2 aiyengar2 added this to the v2.x - Backlog milestone Jan 28, 2022
@aiyengar2
Copy link
Contributor

aiyengar2 commented Jan 28, 2022

Thanks for bringing this up @eliaskoromilas; seems like we need to slightly modify the logic we use to add dependencies to also ensure versions for those dependencies are added.

This will require more investigation, but I think this can be done as part of a new minor release of the charts (since adding the versions to the Chart.yaml will invalidate existing patches recorded in Chart.yaml.patch files, which will require a manual migration process).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team/mapps
Projects
None yet
Development

No branches or pull requests

8 participants