Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release.yaml outputted from make validate should merge with existing contents #77

Open
aiyengar2 opened this issue Feb 10, 2022 · 0 comments
Assignees
Labels
bug Something isn't working team/mapps

Comments

@aiyengar2
Copy link
Contributor

Instead of starting with an empty ReleaseOptions{} here:

releaseYaml := options.ReleaseOptions{}

We should be loading the release.yaml from the existing file (if it exists), since all of our walk functions will not track existing items in the release.yaml that will be dumped anyways:

if releaseOptions.Contains(chart.Metadata.Name, chart.Metadata.Version) {
// Chart is tracked in release.yaml
return nil
}
// Chart exists in local and is not tracked by release.yaml
logrus.Infof("%s/%s is untracked", chart.Metadata.Name, chart.Metadata.Version)
response.UntrackedInRelease = response.UntrackedInRelease.Append(chart.Metadata.Name, chart.Metadata.Version)

@aiyengar2 aiyengar2 self-assigned this Feb 10, 2022
@aiyengar2 aiyengar2 added this to the 0.4.x milestone Feb 10, 2022
@aiyengar2 aiyengar2 added the bug Something isn't working label Feb 10, 2022
@MKlimuszka MKlimuszka modified the milestones: 0.4.x, v2.7.x Jul 12, 2022
@deniseschannon deniseschannon removed this from the v2.7.x milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team/mapps
Projects
None yet
Development

No branches or pull requests

4 participants