Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] open links to foreign sites on a new tab #10438

Closed
harridu opened this issue Feb 10, 2024 · 3 comments
Closed

[RFE] open links to foreign sites on a new tab #10438

harridu opened this issue Feb 10, 2024 · 3 comments

Comments

@harridu
Copy link

harridu commented Feb 10, 2024

Is your feature request related to a problem? Please describe.
To not break the user's context links to the documentation and other remote sites should be opened in a new tab. For example the links on the blank Harvester Clusters page pointing to harvesterhci.io. Of course I could use the built in "open in new tab" feature of chrome and firefox, but usually I forget, and when I finally notice there was no new tab I am frustrated.

IMHO it is good practice.

Rancher is version 2.8.2, browser is Brave (derived from Chromium).

Additional context
https://html.com/attributes/a-target/#a_target8221_blank8221_Open_in_New_Browser_Tab_or_Window

@rak-phillip rak-phillip transferred this issue from rancher/rancher Feb 12, 2024
@rak-phillip
Copy link
Member

@harridu thanks for raising this issue and helping to make Rancher better!

@gaktive I'm transferring this to the dashboard repo for triage.

@rak-phillip
Copy link
Member

I'm unable to reproduce while testing on v2.9-head. It looks like this RFE is a duplicate of a bugs discovered in 2.8

@richard-cox richard-cox added this to the v2.9.0 milestone Feb 15, 2024
@richard-cox
Copy link
Member

There was a general issue with target in 2.8.2 which has been resolved in 2.9-head (2.9.0) via #9920. I've also validated that the blank harvester page links do now open in a new tab

@richard-cox richard-cox closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2024
@zube zube bot closed this as completed Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants