Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: improve to have more logs #163

Closed
2 of 3 tasks
ldevulder opened this issue Jul 12, 2022 · 1 comment
Closed
2 of 3 tasks

e2e: improve to have more logs #163

ldevulder opened this issue Jul 12, 2022 · 1 comment

Comments

@ldevulder
Copy link
Contributor

ldevulder commented Jul 12, 2022

When failures occur we sometimes miss some logs.

It could be useful for some command to, for example, replace this:

err = exec.Command("virsh", "net-create", netDefaultFileName).Run()
Expect(err).To(Not(HaveOccurred()))

by this:

out, err = exec.Command("virsh", "net-create", netDefaultFileName).CombinedOutput()
Expect(err).To(Not(HaveOccurred()), out)

So in case of error we could have the output in Ginkgo logs.

Things to do:

@ldevulder ldevulder moved this from 💡 Untriaged to 🗳️ To Do in Elemental Aug 3, 2022
@kkaempf kkaempf removed this from Elemental Aug 9, 2022
@ldevulder ldevulder moved this to 💡 Incoming in Elemental Aug 22, 2022
@ldevulder
Copy link
Contributor Author

Done.

@github-project-automation github-project-automation bot moved this from 💡 Backlog to ✅ Done in Elemental Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant