Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

symLinkEngineBinary doesn't work with custom docker engine from url #2870

Closed
stffabi opened this issue Aug 14, 2019 · 4 comments
Closed

symLinkEngineBinary doesn't work with custom docker engine from url #2870

stffabi opened this issue Aug 14, 2019 · 4 comments

Comments

@stffabi
Copy link
Contributor

stffabi commented Aug 14, 2019

RancherOS Version: (ros os version)

v1.5.4-rc1

Where are you running RancherOS? (docker-machine, AWS, GCE, baremetal, etc.)

vSphere

symLinkEngineBinary can't detect the docker version if a custom docker engine is used as documented here. In such a case symLinkEngineBinary receives the URL to the engine service file and fails to determine the docker version. Therefore if the custom docker engine is newer or equal to 18.09.0 rancher tries to create the wrong symlinks (e.g. for runc). As a result RancherOS doesn't boot anymore.

@niusmallnan niusmallnan added this to the v1.5.4 milestone Aug 14, 2019
@niusmallnan niusmallnan self-assigned this Aug 14, 2019
@niusmallnan
Copy link
Contributor

I can reproduce this issue with this cloud-config.

#cloud-config 
rancher:
  docker:
    engine: https://raw.githubusercontent.com/rancher/os-services/master/d/docker-18.09.7.yml

@stffabi
Copy link
Contributor Author

stffabi commented Aug 19, 2019

Successfully tested on v1.5.4-rc2

@stffabi
Copy link
Contributor Author

stffabi commented Aug 19, 2019

Thanks for the fix

@kingsd041
Copy link
Contributor

Fixed on v1.5.4-rc2, close this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants