Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: expose VPC field for DigitalOcean node templates #27776

Closed
ASwingler opened this issue Jun 29, 2020 · 2 comments
Closed

Feature Request: expose VPC field for DigitalOcean node templates #27776

ASwingler opened this issue Jun 29, 2020 · 2 comments

Comments

@ASwingler
Copy link

Rancher 2.4.5 has no mechanism to instruct DigitalOcean to create droplets in a particular VPC. They are all created in the default VPC.
The DO API includes a droplet-creation parameter vpc_uuid where a UID for an existing VPC can be input. Please expose this field.

Ideally a list of VPCs would be available as a dropdown but an input field for a user-designated UID would work as a quick-fix.

@GurjinderSingh
Copy link

I have submitted changes to docker/machine Adding Virtual Private Cloud. I hope it is working and approved soon.

Rancher required the following changes will try to play with it once approved from other side.

Disclaimer: These changes are not working right now as we need to change the docker/machine backend.

/dashboard/c/local/explorer/management.cattle.io.dynamicschema/digitaloceanconfig?mode=edit&as=yaml

    vpc_uuid:
      create: true
      default:
        boolValue: false
        intValue: 0
        stringSliceValue: null
        stringValue: ""
      description: VPC network UUID. Get by querying api
      type: string
      update: true

/n/node-templates

,"vpc_uuid": "weed-so-high-to-the-moon"

other UI Changes required

dashboard/edit/node-config.cattle.io.digitaloceanconfig.vue

useful links

https://developers.digitalocean.com/documentation/v2/#droplets

https://developers.digitalocean.com/documentation/v2/#vpcs

The best solution fetch the VPC network list from DO and provide a dropdown 🚀

curl -X GET -H "Content-Type: application/json" -H "Authorization: Bearer b7d03a6947b217efb6f3ec3bd3504582" "https://api.digitalocean.com/v2/vpcs"

@stale
Copy link

stale bot commented Jul 8, 2021

This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions.

@stale stale bot added the status/stale label Jul 8, 2021
@stale stale bot closed this as completed Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants